Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bindings/ruby): setup cucumber tests #1725

Merged
merged 5 commits into from
Mar 21, 2023
Merged

Conversation

PsiACE
Copy link
Member

@PsiACE PsiACE commented Mar 21, 2023

No description provided.

Signed-off-by: Chojan Shang <psiace@outlook.com>
Signed-off-by: Chojan Shang <psiace@outlook.com>
Signed-off-by: Chojan Shang <psiace@outlook.com>
Signed-off-by: Chojan Shang <psiace@outlook.com>
Signed-off-by: Chojan Shang <psiace@outlook.com>
@PsiACE
Copy link
Member Author

PsiACE commented Mar 21, 2023

Although there are recommended layouts for Ruby and Cucumber, in the end I tried to keep it consistent with other projects as much as possible. The test for hello_opendal will be kept until we actually implement the Operator.

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see cucumber has beend added!

@Xuanwo Xuanwo merged commit 32fe0c7 into apache:main Mar 21, 2023
@PsiACE PsiACE deleted the cucumber-ruby branch March 21, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants